Open
Conversation
Member
|
Now you can rebase and add tanpi to math.cpp tests. Somewhere near cospi and sinpi tests |
Contributor
Author
|
I'm not sure how to solve this error: |
Member
These functions are undefined. You need smth like this |
resetius
reviewed
Mar 19, 2026
| HIPSYCL_DEFINE_HIPLIKE_MATH_BUILTIN(__acpp_sinpi, sinpif, sinpi) | ||
| HIPSYCL_DEFINE_HIPLIKE_MATH_BUILTIN(__acpp_tan, tanf, tan) | ||
| HIPSYCL_DEFINE_HIPLIKE_MATH_BUILTIN(__acpp_tanh, tanhf, tanh) | ||
| HIPSYCL_DEFINE_HIPLIKE_MATH_BUILTIN(__acpp_tanpi, tanpif, tanpi) |
Member
There was a problem hiding this comment.
Is it still need ? Please look at cospi sinpi implementation I don’t think they use a similar macro
Contributor
Author
There was a problem hiding this comment.
Three lines above there is sinpi defined like this one, i just copy pasted. Or do you mean that it's not needed because you defined the template function above for tanpi (unlike for sinpi) ?
Member
There was a problem hiding this comment.
Or do you mean that it's not needed because you defined the template function above for tanpi (unlike for sinpi) ?
exactly
ferdymercury
commented
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.