fix sticky-polyfill causing crash on destroy#1118
Merged
kpfefferle merged 2 commits intoAddepar:masterfrom Aug 1, 2024
Merged
Conversation
kpfefferle
approved these changes
Aug 1, 2024
Member
|
This patch is released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a ember-table is initially rendered without a
tfoot, and atfootis added after the initial render (e.g. due to a loading state), the table will cause a crash on destroy.This happens because the
TABLE_POLYFILL_MAPdoes not have an entry for the specifictfootelement and thus, we call.destroy()onundefined.