LazyContainer updates viewport on content.length#17
Merged
ppong merged 1 commit intoAddepar:masterfrom Jan 22, 2013
CrowdStrike:viewport-fix
Merged
LazyContainer updates viewport on content.length#17ppong merged 1 commit intoAddepar:masterfrom CrowdStrike:viewport-fix
ppong merged 1 commit intoAddepar:masterfrom
CrowdStrike:viewport-fix
Conversation
The viewportDidChange method only observed `content`. However, it also relied upon `content.length`. This meant that in some circumstances, the table would not render content that loaded with a delay. This commit changes the dependency to `content.length`.
Gaurav0
pushed a commit
to Gaurav0/ember-table
that referenced
this pull request
Oct 13, 2015
…roup-row can expand/collapse one level group row
billy-addepar
added a commit
that referenced
this pull request
Sep 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The viewportDidChange method only observed
content. However, it also reliedupon
content.length. This meant that in some circumstances, the table wouldnot render content that loaded with a delay. This commit changes the
dependency to
content.length.