Merged
Conversation
billy-addepar
force-pushed
the
billy/send-footer-event
branch
from
b608b9a to
d957c44
Compare
pzuraq
suggested changes
Dec 18, 2017
Contributor
pzuraq
left a comment
pzuraq
left a comment
There was a problem hiding this comment.
@billy-addepar We should fix things upstream if we can.
pzuraq
suggested changes
Dec 18, 2017
Contributor
pzuraq
left a comment
pzuraq
left a comment
There was a problem hiding this comment.
Generally seems good, but let's only use the on style for tests only. Also, can you squash and make sure the commit message is descriptive?
| </div> | ||
| `); | ||
| } else { | ||
| this.on('onTableFooterEvent', callback); |
Contributor
There was a problem hiding this comment.
This style should work all the way through modern Ember versions, we use this in vertical-collection
| this.set('rows', generateRows(10, columnCount)); | ||
| this.set('footerRows', footerRows); | ||
|
|
||
| if (Ember.VERSION >= '1.13') { // eslint-disable-line no-restricted-globals, no-undef |
Contributor
There was a problem hiding this comment.
Ember.VERSION is a string. This comparison works right now because 1.13 was the last of the 1.* cycle, so all versions in 2.* are bigger, string-wise. It would fail when 2.13 >= 2.8 for instance. So, we should always use a semver library, or ember-compatibility-helpers
billy-addepar
force-pushed
the
billy/send-footer-event
branch
from
9f0d1f0 to
d410e26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.