Send swapping columns to outer controller.#469
Merged
billy-addepar merged 2 commits intomasterfrom Dec 19, 2017
Merged
Conversation
Contributor
Author
|
@Addepar/ice |
pzuraq
approved these changes
Dec 19, 2017
Contributor
There was a problem hiding this comment.
I think this is a good API to have. The name may not be very clear, it may make more sense to have it be called onColumnReorder instead since swapping has the connotation of two element swapping places, and in this case we're just moving one column around, but I don't want to hold it up on bikeshedding
Contributor
Author
|
The name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be useful to let controller know when 2 columns have been swapped as in case controller wants to load new data or update table view.