Merged
Conversation
Contributor
Author
|
@Addepar/ice |
Contributor
|
Can we test that behavior? |
Contributor
Author
|
Not sure how we can test that. There is no functionality change |
billy-addepar
force-pushed
the
billy/replace-raf
branch
from
0b8bbcf to
37bd126
Compare
pzuraq
approved these changes
Jan 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace calling RAF with using RAF scheduler so that it could be canceled when component is destroyed.
This also adds destroy state of component inside
ResizeSensorcallback. Under the hood, it is using RAF but since we cannot replace it, we will add destroy state checking before executing the callback.