Conversation
pzuraq
force-pushed
the
cleanup/tests
branch
from
043d5ac to
363208b
Compare
|
@Addepar/ice |
| @argument onFooterEvent; | ||
|
|
||
| @computed('column.valuePath', 'rowValue') | ||
| get footerValue() { |
There was a problem hiding this comment.
why do you need this footerValue for this custom component?
There was a problem hiding this comment.
It's not needed for tests, but the template renders it and it wasn't there. I'd assumed it was meant to be and added it for future tests, because we'll likely want to verify that it works.
There was a problem hiding this comment.
This is a duplication of footerValue in ember-table-footer. I think I put it there in the template but did not actually use it. We can pass footerValue=footerValue in ember-table-footer.
There was a problem hiding this comment.
I don't think we should do that just to reduce code. Going to merge this, we need to keep moving.
There was a problem hiding this comment.
That's good to me. We can clean up this later. I did not mean to bikeshed on this.
| assert.ok(table.rows.length < rowCount, 'not all rows have been rendered'); | ||
| assert.equal(table.getCell(0, 0).text.trim(), '0A', 'correct first row rendered'); | ||
| assert.notEqual( | ||
| table.getCell(table.rows.length - 1, 0).text.trim(), '99A', 'correct last row rendered' |
There was a problem hiding this comment.
I think the message here does not reflect what it test. It should say "Last rendered row is not last data row"
| // scroll all the way down | ||
| await scrollTo('[data-test-body-container]', 0, 10000); | ||
|
|
||
| assert.notEqual(table.getCell(0, 0).text.trim(), '0A', 'correct first row rendered'); |
This PR cleans up the tests by utilizing page objects and breaking out tests into various files. It also attempts to start formalizing some scenario helpers that can be used to run the same modules against multiple scenarios.
pzuraq
force-pushed
the
cleanup/tests
branch
from
6db901a to
280a891
Compare
2 participants
This PR cleans up the tests by utilizing page objects and breaking
out tests into various files. It also attempts to start formalizing
some scenario helpers that can be used to run the same modules against
multiple scenarios.