Skip to content

Tests for sending action up after header reordering & resizing#492

Merged
billy-addepar merged 1 commit intomasterfrom
billy/more-component-tests
Mar 1, 2018
Merged

Tests for sending action up after header reordering & resizing#492
billy-addepar merged 1 commit intomasterfrom
billy/more-component-tests

Conversation

@billy-addepar
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@pzuraq pzuraq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a change in casing to be consistent

Comment thread tests/helpers/generate-table.js Outdated

onColumnReordered() {},

onColumnReSized() {}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onColumnResized

Comment thread addon/components/ember-table.js Outdated
*/
@argument
@type(optional(Action))
onColumnReSized = null;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onColumnResized

@billy-addepar billy-addepar force-pushed the billy/more-component-tests branch from 0545222 to a8dea9c Compare February 27, 2018 17:52
@billy-addepar
Copy link
Copy Markdown
Contributor Author

Method names are updated. The onColumnResized is actually used in one of the current action. I rename it to onColumnReordering to make it clearer

@billy-addepar billy-addepar merged commit 3556fba into master Mar 1, 2018
@bantic bantic deleted the billy/more-component-tests branch July 11, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants