Conversation
| cell=cell | ||
| }} | ||
| {{#ember-table as |t|}} | ||
| {{ember-thead api=t columns=columns}} |
There was a problem hiding this comment.
maybe table=t instead of api=t?
There was a problem hiding this comment.
Yeah I've been going back and forth on that one. On the one hand, it reads better for now, but on the other I think it may actually obfuscate what we're passing in and why. This especially becomes an issue later on:
{{#ember-tbody as |b|}}
{{#ember-tr body=b as |r|}}
{{#ember-td row=r as |value cell column row|}}
^r and row are not the same thing
{{/ember-td}}
{{/ember-tr}}
{{/ember-tbody}}
I think it may make sense to add the name as an alias to each component, so users can choose whichever one makes more sense to them and we can see which is less confusing over time. Once we get to 2.3 we'll be converting to contextual components anyways, so it's not really a big deal either way.
pzuraq
force-pushed
the
pzuraq/restructure/broken-out-api
branch
2 times, most recently
from
d9dea3b to
f55407e
Compare
| @argument | ||
| @type('string') | ||
| @attribute('aria-label') | ||
| ariaLabel; |
There was a problem hiding this comment.
What is this ariaLabel used for ?
There was a problem hiding this comment.
it's for the a11y test, checkboxes are now enabled based on selectMode so they're enabled for all tests. a11y test checks to make sure all form controls are properly labeled.
| cells=cells) | ||
| }} | ||
| {{else}} | ||
| aoeu |
|
LGTM barring some comments |
Refactors to the the broken out table API outlined in #505. Notes: * Lots of APIs renamed and moved * `thead` * `columns` * `numFixedColumns` = `hasFixedColumn` (also now a boolean) * `onColumnResize` => `onResize` * `onColumnReordered` => `onReorder` * `columnMode` => `resizeMode` * `tableResizeMode` => `fillMode` * `tbody` * `tree` * `rows` * `estimateRowHeight` * `onSelect` * `selectedRows` * `selectionMode` => `selectMode` * `tfoot` * `tree` * `rows` * `estimateRowHeight` * `onSelect` * `selectedRows` * `selectionMode` => `selectMode` * Checkboxes now render IFF `onSelect` exists AND `selectMode === 'multiple'`, which is a much easier heuristic to follow and enforces that the checkbox is always in the first cell * Had to restructure the RowWrapper a bit to avoid backtracking rerender * Headers/columns need to be reworked quite a bit, will be doing this in a followup PR
pzuraq
force-pushed
the
pzuraq/restructure/broken-out-api
branch
from
f55407e to
c756e41
Compare
4 participants
Refactors to the the broken out table API outlined in #505. Notes:
theadcolumnsnumFixedColumns=hasFixedColumn(also now a boolean)onColumnResize=>onResizeonColumnReordered=>onReordercolumnMode=>resizeModetableResizeMode=>fillModetbodytreerowsestimateRowHeightonSelectselectedRowsselectionMode=>selectModetfoottreerowsestimateRowHeightonSelectselectedRowsselectionMode=>selectModeonSelectexists ANDselectMode === 'multiple', which is a much easier heuristic to follow and enforcesthat the checkbox is always in the first cell
a followup PR