DOCS: Test that subcolumns docs render cells#710
Merged
bantic merged 1 commit intoAddepar:masterfrom Jul 12, 2019
bantic:bantic/docs/subcolumns-render
Merged
DOCS: Test that subcolumns docs render cells#710bantic merged 1 commit intoAddepar:masterfrom bantic:bantic/docs/subcolumns-render
bantic merged 1 commit intoAddepar:masterfrom
bantic:bantic/docs/subcolumns-render
Conversation
mixonic
approved these changes
Jul 11, 2019
Fix rendering of generated dummy rows. Cells with valuePaths longer than a single character were being skipped over in the dummy row's `unknownProperty` hook. Fix by removing the length check in `unknownProperty` and explicitly adding the needed properties to the class definition so that the only accesses that hit `unknownProperty` should be `valuePath`s for rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of the acceptance tests added by
#709#714 and should not be merged until it lands.Diff of changes unique to this PR.
Fix rendering of generated dummy rows. Cells with valuePaths longer than
a single character were being skipped over in the dummy row's
unknownPropertyhook.
Fix by removing the length check in
unknownPropertyand explicitly addingthe needed properties to the class definition so that the only accesses
that hit
unknownPropertyshould bevaluePaths for rendering.Before:
After:
