Conversation
Remove undefined `py-2` and `pr-4` CSS classes (vestiges from when tailwind was included in the build from addon-docs). Consolidate example options to use `demo-options` class wherever possible. Remove unneeded `demo-option` class. Fix the 'color' property on the columns in the custom-header example so that the correct bg-color CSS classes are applied. Use a separate selection property `demoSelection` for the last demo on the 'row selection' page. When the `selection` property was shared amongst all the demos on the page, it was possible to select a row in one of the demos that didn't exist in the later ones, and would cause an error. Fix typos.
mixonic
approved these changes
Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove undefined
py-2andpr-4CSS classes (vestiges from when tailwindwas included in the build from addon-docs).
Consolidate example options to use
demo-optionsclass wherever possible.Remove unneeded
demo-optionclass.Fix the 'color' property on the columns in the custom-header example so that
the correct bg-color CSS classes are applied.
Use a separate selection property
demoSelectionfor the last demo on the'row selection' page. When the
selectionproperty was shared amongst allthe demos on the page, it was possible to select a row in one of the demos
that didn't exist in the later ones, and would cause an error.
Fix typos.