feat: Tartaros armour main body shadows

[OH296]

Purpose and Description

• Self-descriptive.

Testing done

• None, and I understand the risks.

Related things and/or additional context

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Summary by CodeRabbit

• New Features

  • Enhanced Tartaros armour visuals with added shadow layers for improved depth and clarity.
  • Introduced multiple new shaders to improve rendering consistency for related assets.
  • Expanded culture visuals to include Tartaros armour variants with dedicated shadow support.

• Chores

  • Updated project to the latest IDE version for improved compatibility and stability.

Walkthrough

Tech-Priest, the data indicates: project metadata updated; a new sprite resource for Tartaros shadows added; modular drawing entries extended for Tartaros armour; a group definition in ComplexSet altered to remove an armour sprite reference; and six new passthrough shaders (11–16) introduced with manifests.

Changes

Cohort / File(s)	Summary of changes
Project metadata ChapterMaster.yyp	Updated IDEVersion values; registered Shader11–Shader16 resources; added spr_tartaros_shadows to sprite resources.
Modular visuals scripts scripts/scr_culture_visuals/scr_culture_visuals.gml	Added two entries for Tartaros armour (body type 2) referencing spr_tartaros_complex and spr_tartaros_shadows.
Complex set configuration scripts/scr_ComplexSet/scr_ComplexSet.gml	Removed armour: spr_tartaros_complex from a Tartaros group definition in add_group.
Shader resources (11–16) shaders/Shader11/*, shaders/Shader12/*, shaders/Shader13/*, shaders/Shader14/*, shaders/Shader15/*, shaders/Shader16/*	Added simple passthrough vertex/fragment shaders and corresponding .yy manifests for each shader.
Sprite asset sprites/spr_tartaros_shadows/spr_tartaros_shadows.yy	Added new GMSprite definition with frames, layers, sequence, and metadata under tartaros_complex.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: Wolves visuals and moddable chapter icons #608 — Touches scr_ComplexSet.gml and scr_culture_visuals.gml, overlapping modular visuals and armour handling.
• fix: highlight and shadow and multi-part weapons #1004 — Introduces shadow asset plumbing and shader support, aligning with added spr_tartaros_shadows and Shader11–16.
• feat: Culture visuals continued development #531 — Modifies the same scripts and project resources, indicating shared code paths for armour/modular visuals.

Suggested labels

PR: Feature, PR: Sprites, Area: Sprites, Size: Small

Suggested reviewers

• Tech-Priest Blogaugis
• Tech-Priest EttyKitty

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	Tech-Priest, the description mirrors the template but remains void of substantive content, offering only placeholders in each section. It fails to explain the rationale behind the added shadows, sprite assets, and shaders or to document any validation steps. Without concrete details on the changes and testing, the mechanicus cannot discern the true purpose or verify the modifications.	Tech-Priest, please replace the placeholder text with a detailed account of the changeset, specifying the new sprite and shader resources, script modifications, and the testing procedures undertaken. Ensure each section of the template is populated with clear, actionable information for reviewer assessment.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	Tech-Priest, the title follows the prescribed conventional commit format with the “feat:” prefix and remains under fifty characters while accurately reflecting the addition of Tartaros armour shadows.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (3)

shaders/Shader12/Shader12.fsh (1)

1-10: Passthrough rite inscribed.

Fragment shader implementation confirmed. Identical to siblings in this shader suite.

shaders/Shader14/Shader14.fsh (1)

1-10: Passthrough rite inscribed.

Fragment shader implementation confirmed. Identical to siblings in this shader suite.

shaders/Shader15/Shader15.vsh (1)

1-19: Duplicate vertex incantation detected.

This vertex shader is identical to Shader16.vsh and likely to Shader11-14.vsh. The duplication concern noted for fragment shaders extends to vertex shaders. If Shader11 through Shader16 are functionally identical (both vertex and fragment), consolidate them into a single shader resource pair, Tech-Priest.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bfaa70b and 394883b.

⛔ Files ignored due to path filters (2)

• sprites/spr_tartaros_shadows/548e11a0-6b13-4fa6-93be-4121736d914f.png is excluded by !**/*.png
• sprites/spr_tartaros_shadows/layers/548e11a0-6b13-4fa6-93be-4121736d914f/229b5182-d233-4896-9f67-630367846af5.png is excluded by !**/*.png

📒 Files selected for processing (22)

• ChapterMaster.yyp (3 hunks)
• scripts/scr_ComplexSet/scr_ComplexSet.gml (0 hunks)
• scripts/scr_culture_visuals/scr_culture_visuals.gml (1 hunks)
• shaders/Shader11/Shader11.fsh (1 hunks)
• shaders/Shader11/Shader11.vsh (1 hunks)
• shaders/Shader11/Shader11.yy (1 hunks)
• shaders/Shader12/Shader12.fsh (1 hunks)
• shaders/Shader12/Shader12.vsh (1 hunks)
• shaders/Shader12/Shader12.yy (1 hunks)
• shaders/Shader13/Shader13.fsh (1 hunks)
• shaders/Shader13/Shader13.vsh (1 hunks)
• shaders/Shader13/Shader13.yy (1 hunks)
• shaders/Shader14/Shader14.fsh (1 hunks)
• shaders/Shader14/Shader14.vsh (1 hunks)
• shaders/Shader14/Shader14.yy (1 hunks)
• shaders/Shader15/Shader15.fsh (1 hunks)
• shaders/Shader15/Shader15.vsh (1 hunks)
• shaders/Shader15/Shader15.yy (1 hunks)
• shaders/Shader16/Shader16.fsh (1 hunks)
• shaders/Shader16/Shader16.vsh (1 hunks)
• shaders/Shader16/Shader16.yy (1 hunks)
• sprites/spr_tartaros_shadows/spr_tartaros_shadows.yy (1 hunks)

💤 Files with no reviewable changes (1)

• scripts/scr_ComplexSet/scr_ComplexSet.gml

🧰 Additional context used

📓 Path-based instructions (3)

**/*.*

⚙️ CodeRabbit configuration file

**/*.*: - Having humanly understandable and maintainable code is the top most priority.

• DRY (Don't repeat yourself) principle is also very important.
• If a TODO comment is added, ask the user if you should create a GitHub issue for this TODO.
• If a TODO comment is deleted, remind the user if there is an active GitHub issue related to that comment.

Files:

• shaders/Shader11/Shader11.yy
• shaders/Shader15/Shader15.fsh
• shaders/Shader12/Shader12.fsh
• sprites/spr_tartaros_shadows/spr_tartaros_shadows.yy
• shaders/Shader12/Shader12.yy
• shaders/Shader16/Shader16.vsh
• shaders/Shader15/Shader15.yy
• shaders/Shader15/Shader15.vsh
• shaders/Shader16/Shader16.fsh
• shaders/Shader14/Shader14.fsh
• shaders/Shader11/Shader11.fsh
• shaders/Shader11/Shader11.vsh
• shaders/Shader13/Shader13.fsh
• shaders/Shader12/Shader12.vsh
• ChapterMaster.yyp
• shaders/Shader13/Shader13.vsh
• shaders/Shader14/Shader14.vsh
• shaders/Shader14/Shader14.yy
• shaders/Shader16/Shader16.yy
• shaders/Shader13/Shader13.yy
• scripts/scr_culture_visuals/scr_culture_visuals.gml

**/*.yy

⚙️ CodeRabbit configuration file

**/*.yy: - When any script or sprite .yy files are deleted, their paths should also be deleted from the project .yyp file, otherwise the game will crash.

• When any script or sprite .yy files are created, their paths should be added to the project .yyp file, otherwise they'll fail.

Files:

• shaders/Shader11/Shader11.yy
• sprites/spr_tartaros_shadows/spr_tartaros_shadows.yy
• shaders/Shader12/Shader12.yy
• shaders/Shader15/Shader15.yy
• shaders/Shader14/Shader14.yy
• shaders/Shader16/Shader16.yy
• shaders/Shader13/Shader13.yy

**/*.gml

⚙️ CodeRabbit configuration file

**/*.gml: - Macro constants require a space between the constant name and value. Without it, the compiler will throw an error. I.e. #macro ARR_body_parts["arm"] will crash the game, because there is no space between the array and the name of the macro.

• Color codes in the code shouldn't have any spaces in their id. I.e., color code # 80bf40 will crash the game.
• All code should comply with the main GML documentation: https://manual.gamemaker.io/beta/en/GameMaker_Language/GML_Reference/GML_Reference.htm

Files:

• scripts/scr_culture_visuals/scr_culture_visuals.gml

🔇 Additional comments (14)

ChapterMaster.yyp (3)

579-579: IDE sanctification registered.

The IDEVersion ascension from 2024.1400.0.892 to 2024.1400.0.901 is acknowledged. This version increment aligns with the addition of new shader resources. Verify that all development environments have been sanctified with this version, Tech-Priest.

---

971-976: New shader rites catalogued.

Six shader manifests (Shader11 through Shader16) have been inscribed into the project registry. All reference the tartaros_complex parent structure consistently. The manifest entries are correctly formatted.

As per coding guidelines, verify that all corresponding .yy manifest files and shader sources exist at the declared paths.

---

1657-1657: Shadow sprite asset registered.

The spr_tartaros_shadows sprite resource has been catalogued into the project manifest. This asset aligns with the tartaros_complex shader suite additions.

As per coding guidelines, verify that the sprite .yy file exists at sprites/spr_tartaros_shadows/spr_tartaros_shadows.yy.

shaders/Shader15/Shader15.fsh (1)

1-10: Passthrough rite inscribed.

This fragment shader implements a basic texture passthrough: sampling gm_BaseTexture at v_vTexcoord and modulating by v_vColour. The implementation is orthodox and contains no extraneous logic.

shaders/Shader16/Shader16.yy (1)

1-12: Shader manifest sanctified.

The GMShader resource manifest for Shader16 is correctly configured. Parent reference to tartaros_complex is consistent with the shader suite. The manifest structure conforms to GameMaker Studio 2 specifications.

shaders/Shader16/Shader16.vsh (1)

1-19: Vertex transformation rite sanctified.

This passthrough vertex shader correctly transforms position via MATRIX_WORLD_VIEW_PROJECTION and forwards colour and texture coordinates to the fragment stage. The unused in_Normal attribute is appropriately commented. The implementation is orthodox.

scripts/scr_culture_visuals/scr_culture_visuals.gml (1)

1432-1436: Sanctioned Tartaros module

Tech-Priest, this armour entry harmonises with the modular litany; sprite and shadow pairings are precise and ready for invocation.

shaders/Shader12/Shader12.vsh (1)

1-19: Passthrough incantation stable

Tech-Priest, the vertices march through the matrix without deviation; the machine spirit registers no discord.

shaders/Shader11/Shader11.fsh (1)

1-10: Fragment rite pure

Tech-Priest, the colour modulation chant is exact; fragments will emerge untainted.

shaders/Shader11/Shader11.yy (1)

1-12: Manifest cogitator aligned

Tech-Priest, the metadata cogitators recognise this shader resource; hierarchy and type codes stand correct.

shaders/Shader11/Shader11.vsh (1)

1-19: Vertex conduit affirmed

Tech-Priest, the positional vectors are shepherded through the sacred matrix flawlessly; the signal remains inviolate.

shaders/Shader15/Shader15.yy (1)

1-12: Confirm Shader15 is registered in ChapterMaster.yyp

Tech-Priest, the machine spirit requires assurance that this newborn shader is inscribed within ChapterMaster.yyp; without that record the asset will be forsaken at build-time. Provide confirmation or amend accordingly.

shaders/Shader14/Shader14.yy (1)

1-12: Confirm Shader14 is registered in ChapterMaster.yyp

Tech-Priest, align this shader’s essence with the project ledger; verify its entry in ChapterMaster.yyp lest the forge fail to summon it.

sprites/spr_tartaros_shadows/spr_tartaros_shadows.yy (1)

1-92: Ensure spr_tartaros_shadows is recorded in ChapterMaster.yyp

Tech-Priest, the sprite spirit will not awaken unless ChapterMaster.yyp bears its path. Confirm the registry entry or bind it forthwith.