feat: Trait Removal

[Blogaugis]

Purpose of changes

After discussing that certain traits do not have weight in the game and that there already are traits that function in a similar way, a simple and straightforward solution is to remove them.

Describe the solution

Remove traits.

Describe alternatives you've considered

Upgrade chapter customization options with a larger scale rework of chapter creation screen.

Testing done

• Compilation;
• Making to the game;
• Ending a turn.

Related links

#491 and #527 .

Player notes

Remove Depleted Gene-seed stocks and Enduring Angels. Sieged already does what the EA was doing.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Refactor
  • Updated the chapter setup by removing conditions that previously reduced starting gene resource values, leading to a more consistent initial setup.
  • Removed the "Depleted Gene-seed Stocks" and "Enduring Angels" disadvantages to simplify gameplay mechanics.

Walkthrough

By the Machine Spirit’s decree, the alterations have excised the conditional rites that once modified the gene_seed value in the objects/obj_controller/Create_0.gml file based on the disadvantages "Enduring Angels" and "Depleted Gene-seed Stocks". Furthermore, the corresponding entries for these disadvantages have been removed from the all_disadvantages array in the objects/obj_creation/Create_0.gml file. The remaining logic and declarations of public or exported entities remain untouched, thereby simplifying the conditions under which gene_seed is determined. The operation streamlines the process by reducing disparate influences on this variable, aligning the code closer to its intended reliability in data manipulation.

Possibly related PRs

• fix: Trait cost adjustments #490: This PR also involves removing the same disadvantages from the all_disadvantages array, directly reflecting the adjustments made to gene_seed.
• feat: Add "Depleted Gene-seed Stocks" disadvantage #527: This PR interacts with the same disadvantage, "Depleted Gene-seed Stocks", adding a divergent condition from which contrasts with the removals in this update, thereby establishing a code-level conflict.

Suggested labels

PR: Fix

Suggested reviewers

• OH296

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6b51f6 and 70ab449.

📒 Files selected for processing (2)

• objects/obj_controller/Create_0.gml (0 hunks)
• objects/obj_creation/Create_0.gml (0 hunks)

💤 Files with no reviewable changes (2)

• objects/obj_creation/Create_0.gml
• objects/obj_controller/Create_0.gml

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Blogaugis]

@KRdaMystic @MCPO-Spartan-117
If you have more traits needing the nuclear option, feel free to add more.

[MCPO-Spartan-117]

https://discord.com/channels/714022226810372107/1121959429546455050/1346425902933868625

[github-actions]

This PR is marked as stale, because it has been open for 7 days with no activity.

[Blogaugis]

This thing will also probably bother me with thousands of changes.