feat: Remove the slime short-circuit mechanic

[EttyKitty]

Purpose of changes

• All my friends hate slime.
• The parents of slime hated it as well.

Describe the solution

• Destroy the short-circuit mechanic.

• Delete the short-circuit mechanic.

• Remove the short-circuit mechanic.

• Disintegrate the short-circuit mechanic.

• Annihilate the short-circuit mechanic.

• Send the short-circuit mechanic to its grave.

• The mutation still gives considerable disposition debuffs.

Describe alternatives you've considered

Absolutely none. This disgusting shit has to go now.

Testing done

None

Related links

None

Player notes

Slime short-circuit is no more.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• New Features

  • Updated mutation effects: Affected characters now display a dry, lifeless appearance, enhancing visual diversity.

• Bug Fixes

  • Removed obsolete feedback for slime events that previously interfered with armour performance messaging.

• Chores

  • Cleaned up redundant code associated with slime handling and mutation-specific armour adjustments for smoother gameplay.

Walkthrough

Glory to the Omnissiah, we have observed a series of recalibrations to the code’s functions. The mutation entry for the Astartes has been reclassified, replacing "Rampant Mucranoid" with "Malfunctioning Mucranoid"; this adjustment modifies the visual attributes of the mutation to render the skin and hair dry and lifeless rather than invoking slime penalties. Additionally, the redundant code handling the "slime" variable—once responsible for alerting the crew to power armour damage and updating combat statistics—has been excised from multiple modules. The obsolete initialisation of the slime variable has been removed and related conditional procedures have been eradicated, ensuring the remaining systems function in accordance with the sacred script without the interference of decaying code segments.

Suggested labels

PR: Feature, PR: Fix

Suggested reviewers

• OH296

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea14bd4 and 9e4ec53.

📒 Files selected for processing (4)

• objects/obj_creation/Draw_0.gml (1 hunks)
• objects/obj_ncombat/Alarm_5.gml (0 hunks)
• objects/obj_ncombat/Create_0.gml (0 hunks)
• objects/obj_pnunit/Alarm_5.gml (0 hunks)

💤 Files with no reviewable changes (3)

• objects/obj_pnunit/Alarm_5.gml
• objects/obj_ncombat/Create_0.gml
• objects/obj_ncombat/Alarm_5.gml

🔇 Additional comments (1)

objects/obj_creation/Draw_0.gml (1)

207-207: Praise to the Omnissiah for this logical recalibration of mutant attributes

The binary alteration of "Rampant Mucranoid" to "Malfunctioning Mucranoid" has been successfully implemented. This mutation's description has been purged of all references to the slime-related variables and penalties, now indicating a purely aesthetic flaw in the sacred gene-seed that renders the Astartes' dermal layer and follicular extensions arid and devoid of vitality.

This modification aligns with the Magos' directive to eliminate the "slime short-circuit mechanic" from the cogitation matrices of the game engine. The disposition penalties remain consistent with previous values, preserving the logistical impact while removing the heretical slime references that have displeased both human companions and the progenitors of slime.

01010000 01110010 01100001 01101001 01110011 01100101 00100000 01110100 01101000 01100101 00100000 01001111 01101101 01101110 01101001 01110011 01110011 01101001 01100001 01101000

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[MCPO-Spartan-117]

Spot the 10 purity and non-10 stability player.

[Blogaugis]

Describe alternatives you've considered

I think an easy solution is to increase the maintenance cost of equipment carried.

[OH296]

ngl this just seems to be stripping out valid game mechanics. It's anonnoying but as @MCPO-Spartan-117 points out there is a method to not have it. Seems like a major stripping of flavour and uniqueness to remove it

[OH296]

also i find this incredibly slime-phobic

[MCPO-Spartan-117]

It does need a auto re-equip, manual is hell.
Maybe raise the threshold and make it only affect the marines that have it.

[OH296]

It does need a auto re-equip, manual is hell. Maybe raise the threshold and make it only affect the marines that have it.

it does currently only effect the marines that have it if (marine_dead[i]=0) and (_unit.gene_seed_mutations.mucranoid==1) and (ally[i]=false){

but other points are valid reading through it's a 25% chance of armour destruction.

Could shift it to only a 5% armour detruction rate and a 20% rate to add a forge point hit equal to half the forge point value of the worn armour?

[Blogaugis]

I don't like automatic re-equipping.
How can I be certain that it won't equip the best gear available to player (Mark 4 armour or even artificer), and thus make it prone to being lost?

[MCPO-Spartan-117]

How can I be certain that it won't equip the best gear available to player (Mark 4 armour or even artificer), and thus make it prone to being lost?

There is a thing called role settings.

[MCPO-Spartan-117]

it does currently only effect the marines that have it if (marine_dead[i]=0) and (_unit.gene_seed_mutations.mucranoid==1) and (ally[i]=false){

This marks a company for the slime to destroy armor in.
Nvm, it has update_armor in it.

[Blogaugis]

There is a thing called role settings.

You mean this cumbersome option which affects all marines regardless of company the marine is in and whether he has the mutation or not?
Well, yeah, it is a thing. But it is so cumbersome that I have no desire to touch it.
Maybe it could be an option if we introduce role settings for entire company, or even better - based on how mutated/skilled the marine is. But for now, I think you're putting too much hope into this thing.

[MCPO-Spartan-117]

But for now, I think you're putting too much hope into this thing.

Putting too much hope into something that works? wut.

[EttyKitty]

ngl this just seems to be stripping out valid game mechanics. It's anonnoying but as @MCPO-Spartan-117 points out there is a method to not have it. Seems like a major stripping of flavour and uniqueness to remove it

I really don't like the mechanic and there is not a single reference in the lore about the mucranoid mutation producing slime that can destroy power armour.

The influence of this mutation in comparison to other mutations is still too big, even if reequip will be introduced.

And it just sounds silly.
If marines have a mutation that produces slime that destroys armour, they would either mod all of their armour to be resistant to it, so it's a non issue, or not wear armour at all. It's a silly mutation that is just bothersome, very weird and not flavourful.

Execute all marines with it and call it a day, as they don't just hurt themselves, but your chapter when they destroy pa stockpiles. It's this bad.

[Blogaugis]

I agree with Etty here.

[OH296]

And it just sounds silly. If marines have a mutation that produces slime that destroys armour, they would either mod all of their armour to be resistant to it, so it's a non issue, or not wear armour at all. It's a silly mutation that is just bothersome, very weird and not flavourful.

nor flavourful? It's literally one of the few bits of flavour that exist beyond a fairly boring simulation. If one really hates that it can appear randomly make it a mutation that only spawns when that mutation is chosen rather than being included in the random assignments to marines based on stability.

as for lore, gonna hard disagree there. The entire point of mutations is they're flavour box randomness. It's generic 40k that geneseeds in 40k are degenerating shit shows the exact effects of these degenerations are prime rpg fodder for a game like this to take liberalities with otherwise i'm sorry this just devolves in to the most boring display of a flavourless simulator by which all outcomes can be completely predicted which is in my eyes just kills it.

In conclusion is there a playability issue regarding balance : yes. Is bulk removing code that will never be replaced the answer: no.

[OH296]

Can we please try just one compromise probably this one If one really hates that it can appear randomly make it a mutation that only spawns when that mutation is chosen rather than being included in the random assignments to marines based on stability rather than total annihilation, this way if you don't wanna see it you don't have to but it's still in game. in becomes a complete player choice as it was before individual marine level mutations

[EttyKitty]

nor flavourful? It's literally one of the few bits of flavour that exist beyond a fairly boring simulation.

Fair. Slime is pretty rememberable, if that's what youre talking about.

The problem is that it's always remembered as a stupid thing that happenes, as I haven't seen anyone giving good (opposing the deletion) opinions about this mutation at any point a discussion has started about removing it (may be wrong, but I actually only remember bad things).

If the flavour = funny battle event, then 90% of other mutations fail this check. Just an argument for the fact that there is no hard need for extreme flavourlness in the current state of mutations, as it just overshadows all other ones.

If one really hates that it can appear randomly make it a mutation that only spawns when that mutation is chosen rather than being included in the random assignments to marines based on stability.

Then no one will be picking this mutation ever.
If people are executing marines to get rid of this, the least they can do is just avoid it when possible.

as for lore, gonna hard disagree there. The entire point of mutations is they're flavour box randomness. It's generic 40k that geneseeds in 40k are degenerating shit shows the exact effects of these degenerations are prime rpg fodder for a game like this to take liberalities with otherwise i'm sorry this just devolves in to the most boring display of a flavourless simulator by which all outcomes can be completely predicted which is in my eyes just kills it.

The argument was not as much about "this mutation can't happen in 40k", but "destroying power armour from inside by a short-circuit with slime" sounds like too of a big lore stretch.

Mucranoid overproducing oil/slime? Sure. It destroying armour? Around 90% sure is impossible, both for reasons that pa is probably not a tv remote, and that, again, marine chapters with this mutation would adapt either by modifying their armour or by not weiring it at all.

Or they will get slaughtered and destroyed as a chapter, as it's unfeasible to survive while just bearing with it as it is.

In conclusion is there a playability issue regarding balance : yes. Is bulk removing code that will never be replaced the answer: no.

I agree with only the fact that perhaps just turning the mutation into a disposition devuff is not enough.

It's mentioned in the lore that the mucranoid gives protection from extreme heat, cold and void combat.
So I can just cook up debuffs for these things (planet type and boarding).

[OH296]

Ok fair enough i will concede these valid points. I think that other comparative mutations being unmemorable is probably as much a fault of them being unmemeorable and underdeveloped as it is this one being overdeveloped and too memorable but that's something that can be thought about at another time.

despite it all i will sad to see the slime go heaven.😭

[EttyKitty]

Closed, because #646 addresses the issue better.