Build on NetBSD #8142
Open
Build on NetBSD #8142
+92
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Comment on lines
+54
to
+55
| default: | ||
| return nil, false, s.Err() |
There was a problem hiding this comment.
In the rcConfStaticConfig method, when a valid static IP configuration is found in the default case, it returns nil, false, s.Err(). This will stop the file walking but doesn't indicate that a static IP was found.
The function should return a value indicating success (like true) as the first return parameter when a static IP is found. Otherwise, the ifaceHasStaticIP function will always return false for the ok parameter, even when a static IP exists.
Suggested change
| default: | |
| return nil, false, s.Err() | |
| default: | |
| return []string{"static IP found"}, false, nil |
Author
There was a problem hiding this comment.
As I mentioned, this is exactly the same code as in net_freebsd.go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for NetBSD.
This issue #4127 is still open for 3 years, so let's get it done.
Note:
internal/aghnet/net_netbsd.gois identicalinternal/aghnet/net_freebsd.go.