Merged
Conversation
Owner
|
Hello Shichien, thank you for these additions to the mod! I've reviewed and tested it, and everything seemed to work well. Merging this in! |
AdiPrk
pushed a commit
that referenced
this pull request
Mar 19, 2026
Fixed issues with compression, json, and various other errors showing up in logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structural Refactor for Hollow Knight and Silksong
This PR restructures ReplayTimerMod into a cleaner dual-platform layout for both Hollow Knight and Silksong.
Thanks to the author's project. In the speedrun community, several people felt it could also serve as a useful tool for Hollow Knight practice. Considering that Team Cherry reused a large amount of Hollow Knight's code when developing Silksong, I think some of the logic might also be reusable. Through a period of Vibe Coding and Tests, I have successfully run this Mod on Hollow Knight, so I submit the PR.
I'm not a native English speaker, so I hope this fairly large PR is still clear enough. I also hope it can be useful for future speedrun practice. If your intention is to keep the ReplayTimer repo only for Silksong, I completely understand. In that case, I can fork it.
Scope Notes
What Changed
src/Generalandsrc/General/UI.src/HollowKnightsrc/SilksongBuild
dotnet build src/Silksong/ReplayTimerMod.SS.csproj -c Releasedotnet build src/HollowKnight/ReplayTimerMod.HK.csproj -c ReleasePreview