fix(api): prevent duplicate review flooding by using upsert on user-entity pair#48
Merged
Merged
Conversation
… user-entity pair POST /api/reviews had no rate limit or duplicate guard. An authenticated user could automate thousands of requests, filling the database with duplicate reviews and polluting the activity feed. Replace prisma.review.create with prisma.review.upsert keyed on the unique compound index (userId, entityType, entityId). A repeated submission now updates the existing review instead of inserting a new row. The feed event is only emitted for genuinely new reviews, not for updates, keeping the activity feed accurate. Closes AditthyaSS#38
|
@anshul23102 is attempting to deploy a commit to the aditthyass' projects Team on Vercel. A member of the Team first needs to authorize it. |
AditthyaSS
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
POST /api/reviewshad no duplicate guard or rate limit. An authenticated user could automate thousands of requests, inserting duplicate review rows and creating noise in the activity feed for all users. Each submission created two database rows (onereview, onefeedEvent), compounding the damage.Related Issue
Closes #38
Type of Change
Root Cause
prisma.review.createwas called unconditionally. There was no uniqueness constraint enforced at the API level, and the databaseuserId + entityType + entityIdcombination was not used as a deduplication key.Changes Made
src/app/api/reviews/route.tsprisma.review.createwithprisma.review.upsertkeyed onuserId_entityType_entityIdsrc/app/api/reviews/route.tscreatedAt === updatedAt), preventing duplicate feed entries on updatesHow It Works
A repeat submission from the same user for the same entity now updates the existing review instead of inserting a new row. No external rate-limit store or Redis is required. The database unique index acts as the authoritative deduplication gate.
Screenshots or Demo
Not applicable (no UI change).
Testing Done
Checklist
NSoC Label Request
@AditthyaSS could you please add the appropriate NSoC '26 label to this PR? Thank you!