Skip to content

Conversation

@erikmarr
Copy link
Contributor

@erikmarr erikmarr commented Jan 7, 2026

Pull request overview

This pull request adds documentation for error handling behavior in the Live Search productSearch query when sorting by category position with an empty or invalid categoryPath. The new section explains how the Search Service gracefully handles such requests by falling back to relevance-based sorting and returning a structured GraphQL warning instead of throwing a FAILED_PRECONDITION error.

Key changes:

  • Documents the fallback behavior when position sorting is attempted with invalid categoryPath
  • Provides the structure of the warning message returned in the errors array
  • Includes an example query that triggers this warning scenario
  • https://jira.corp.adobe.com/browse/MSRCH-5304

Affected pages

Copilot AI review requested due to automatic review settings January 7, 2026 17:28
@erikmarr erikmarr self-assigned this Jan 7, 2026
@github-project-automation github-project-automation bot moved this to 📋 Needs Review in Commerce - Pull Requests Jan 7, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds documentation for error handling behavior in the Live Search productSearch query when sorting by category position with an empty or invalid categoryPath. The new section explains how the Search Service gracefully handles such requests by falling back to relevance-based sorting and returning a structured GraphQL warning instead of throwing a FAILED_PRECONDITION error.

Key changes:

  • Documents the fallback behavior when position sorting is attempted with invalid categoryPath
  • Provides the structure of the warning message returned in the errors array
  • Includes an example query that triggers this warning scenario

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kiranv926
Copy link

Looks good to me. 👍

@github-project-automation github-project-automation bot moved this from 📋 Needs Review to 👍 Approved in Commerce - Pull Requests Jan 7, 2026
erikmarr and others added 2 commits January 7, 2026 15:38
Co-authored-by: Kevin Harper <keharper@users.noreply.github.com>
Co-authored-by: Margaret Eker <meker@adobe.com>
@erikmarr erikmarr merged commit 6897a21 into main Jan 8, 2026
25 checks passed
@erikmarr erikmarr deleted the em_ls-categorypath branch January 8, 2026 22:41
@github-project-automation github-project-automation bot moved this from 👍 Approved to 🏁 Done in Commerce - Pull Requests Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

5 participants