[ADS-276] Update readme & rename submodules into sample #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonCziken
reviewed
Feb 27, 2021
.gitmodules
Outdated
| @@ -1,3 +1,3 @@ | |||
| [submodule "submodules/client-libs-java-samples"] | |||
Collaborator
There was a problem hiding this comment.
don't we need to change this line as well ?:)
Collaborator
Author
There was a problem hiding this comment.
This part of the .gitmodules file contains the name the submodule,
and it does not have to match the path to it.
To move the submodule I've used an intended git command:
git mv submodules/ sample/ that has not changed the name.
Nevertheless, even if it's not required, it's good to keep it in sync,
so I've just updated the name also. Thanks for spotting that!
iterativepianist
force-pushed
the
feature/ADS-276_update_readme_1.0.4
branch
from
3d7cf3d to
a635e33
Compare
iterativepianist
changed the title
Give 'submodules' directory for more meaningful name.
SignatureVerifier may take multiple ipAddresses as parameter, from multiple sources (e.g httpXForwardForIpAddresses and remoteIpAddresses headers), internally check all against signature and in case of the correct result returns IPs that matched with the signature.
iterativepianist
force-pushed
the
feature/ADS-276_update_readme_1.0.4
branch
from
7c6c326 to
953b9f7
Compare
iterativepianist
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR contains only minor changes, that don't require lifting the version of the library.