Skip to content

Added docker deployment code#71

Merged
AdtSri413 merged 2 commits intomainfrom
feature/Shawn-Malthus/PROJ-503/Deploying-the-web-application
Nov 23, 2022
Merged

Added docker deployment code#71
AdtSri413 merged 2 commits intomainfrom
feature/Shawn-Malthus/PROJ-503/Deploying-the-web-application

Conversation

@paynwahs
Copy link
Copy Markdown
Collaborator

AUTHOR(S)

Yap Yu Xiang Shawn, Malthus Oh Teng Jie

SPRINT AND STORY

Sprint 5 - PROJ-503

DESCRIPTION

Added Dockerfile which creates the image for the qbnb web application and docker-compose sets up and connects all services together

TESTING

Ran "docker-compose up" and visited the website successfully.
Ran pytest and flake8 which return successful results.

CHECKLIST:

Please ensure that your changes/pull request meet the following requirements before submitting:

  • If submitting python code, my code follows the PEP8 style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Parts of this document were taken from the following example template:

https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/

@paynwahs paynwahs added this to the Assignment 4 milestone Nov 23, 2022
@AdtSri413 AdtSri413 modified the milestones: Assignment 4, Assignment 5 Nov 23, 2022
@AdtSri413 AdtSri413 linked an issue Nov 23, 2022 that may be closed by this pull request
Copy link
Copy Markdown
Owner

@AdtSri413 AdtSri413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AdtSri413 AdtSri413 merged commit b5aadb4 into main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PROJ-503 - Deploying the Web Application

2 participants