Skip to content

Conversation

@StefanGreve
Copy link
Member

No description provided.

@StefanGreve StefanGreve added the enhancement New feature or request label Jul 8, 2024
@StefanGreve StefanGreve self-assigned this Jul 8, 2024
…ficateService

* The default implementation of CertificateStore is still tighly coupled
  to the X509Store. Because it is a thin wrapper over a native library,
  testing this service won't be necessary.
* The GetCertificate extension method now also returns invalid
  certificates, so that the caller side can take over the burden of
  validation, which also happens to make writing the unit tests much
  easier.
@StefanGreve StefanGreve added this to the Version 8.0.0-alpha milestone Jul 9, 2024
@StefanGreve StefanGreve added documentation Improvements or additions to documentation tests Work on test suite labels Jul 9, 2024
@StefanGreve StefanGreve linked an issue Jul 9, 2024 that may be closed by this pull request
8 tasks
@StefanGreve StefanGreve marked this pull request as ready for review July 12, 2024 17:36
@StefanGreve StefanGreve merged commit 58ba89b into master Jul 12, 2024
@StefanGreve StefanGreve deleted the cert_service_test branch July 12, 2024 19:00
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request tests Work on test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement CertificateService

2 participants