-
Notifications
You must be signed in to change notification settings - Fork 36
Add Cinema: Debye-Scherrer export to Sequential Rietveld Fits #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se keyword 'file'
to keep up to date with main branch
Contributor
|
I added some minor improvements to #236. With them, everything is ready for merging. |
Collaborator
Author
|
MacOS failure is a pixi problem, unrelated to this and also something I'm not sure how to fix. |
Collaborator
Author
|
This has been superceded by #236 |
…used (file_path is redefined prior to use
Collaborator
Author
|
Seems ready to go... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to complete issue #11, which seems to be in reasonable shape but will wait for comments from @AndrewKuncevich