synthesis sparse dictionary learning + rPIE for accelerated probe recovery through dimension reduction #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 18, 2025 08:40
recovery through dimension reduction
mdw771
force-pushed
the
sDL_rPIE_single_slice_only
branch
from
4aa5d76 to
8656354
Compare
mdw771
requested changes
Apr 18, 2025
Collaborator
mdw771
left a comment
mdw771
left a comment
There was a problem hiding this comment.
Good work - just a few comments, mostly on code style. Please also add a tester.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the changes Ming and Ash have made so that we can use sythesis sparse dictionary learning for accelerated probe recovery through dimension reduction by solving for a sparse code vector instead of the original dense probe representation.
My Zernike 2D basis function generator is still very slow, so I need load an already created dictionary in the driver script; I'm currently looking into accelerating this Zernike 2D basis function generator using GPU + pytorch.
I will include the pre-made dictionary in the APS gitlab account for PtyChi.