all unmeasured pixels treated as unconstrained#64
Merged
Conversation
where we do not enforce the measurement constraint. this fix allows us to treat all unmeasured pixels as unconsstrained
…ake it a threshold, move it to `ReconstructorOptions`, and remove unnecessary plumbing
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently we use a fixed unmeasured pixel binary mask to define regions where we do not enforce the measurement constraint. this fix allows us to treat all unmeasured pixels as unconstrained.
this was an issue for us for recent beamtime where some measurements had saturated low Q pixels, and by enforcing these saturated pixels, the reconstruction would have crappy artifacts.
we tried to zero these pixels out, and enforced those zeroed out low Q regions, but this would cause another set of crappy artifacts.
simply leaving all unmeasured pixels unconstrained when performing exitwave updates solved this problem for us, and here's the code I used to make this happen.