Skip to content

Seperate Linting workflow; Setup pre-commit#9

Merged
someshsingh22 merged 13 commits intoAdversarial-Deep-Learning:mainfrom
Devanshu24:CI
Aug 7, 2021
Merged

Seperate Linting workflow; Setup pre-commit#9
someshsingh22 merged 13 commits intoAdversarial-Deep-Learning:mainfrom
Devanshu24:CI

Conversation

@Devanshu24
Copy link
Copy Markdown
Contributor

@Devanshu24 Devanshu24 commented Aug 6, 2021

Mainly a PR to clean up the CI workflows and add a few more useful ones
Feedback/Suggestions are welcome!

Fixes #10

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@b49ef20). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9bf9ebf differs from pull request most recent head 5e3bc4b. Consider uploading reports for the commit 5e3bc4b to get more accurate results

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage        ?   80.00%           
=======================================
  Files           ?        2           
  Lines           ?        5           
  Branches        ?        0           
=======================================
  Hits            ?        4           
  Misses          ?        1           
  Partials        ?        0           

@Devanshu24 Devanshu24 changed the title [WIP] Seperate Linting workflow; Setup pre-commit Seperate Linting workflow; Setup pre-commit Aug 7, 2021
@Devanshu24
Copy link
Copy Markdown
Contributor Author

@someshsingh22 Have a look, changed quite a few things but hopefully it should all work now

@someshsingh22
Copy link
Copy Markdown
Member

We have changed the repository name in the latest PR #8, can you rename code-soup to code_soup ? Its causing issues in the Imports @Devanshu24

Copy link
Copy Markdown
Member

@someshsingh22 someshsingh22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the renaming is supposed to be code_soup for the time being

@someshsingh22 someshsingh22 self-requested a review August 7, 2021 10:37
@someshsingh22
Copy link
Copy Markdown
Member

@Devanshu24 Latest PR has caused some merge conflicts, you can overwrite them

@someshsingh22 someshsingh22 removed their request for review August 7, 2021 10:43
@Devanshu24
Copy link
Copy Markdown
Contributor Author

Devanshu24 commented Aug 7, 2021

There will be linting failures from #9
I think we should resolve them after merging this, to avoid cluttering a single PR

@someshsingh22
Copy link
Copy Markdown
Member

Great so I am merging this and we can set up a final cleanup

@someshsingh22 someshsingh22 reopened this Aug 7, 2021
@someshsingh22 someshsingh22 merged commit 09d01a5 into Adversarial-Deep-Learning:main Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CodeCoverage Report Missing

2 participants