PW-4390 Added Apache HTTP Client & added get and update paymentLink #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Apache HTTP client to support PATCH, GET & DELETE request methods. - Moved create paymentLink to PaymentLinks service - Added Get and Updated paymentLink into PaymentLinks service
saquibsayyad
requested review from
Aleffio,
abhilash-adyen,
andrei-dediu,
martinsrenato and
rkewlani
as code owners
|
This pull request introduces 1 alert when merging 558d2c9 into 65eadba - view on LGTM.com new alerts:
|
Aleffio
reviewed
Apr 29, 2021
Aleffio
reviewed
Apr 30, 2021
Aleffio
previously approved these changes
May 3, 2021
andrei-dediu
previously approved these changes
May 6, 2021
rkewlani
reviewed
May 11, 2021
|
|
||
| class AdyenResponse { | ||
|
|
||
| private String response; |
There was a problem hiding this comment.
May be it will be good to call this as body
Aleffio
approved these changes
May 11, 2021
andrei-dediu
approved these changes
May 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested scenarios
E2E tests (including payment link create, get & update)