Skip to content

Added methods to query and post strongly typed points using attributes#99

Merged
mvadu merged 6 commits intoAdysTech:masterfrom
tituszban:strongly-typed
Aug 26, 2020
Merged

Added methods to query and post strongly typed points using attributes#99
mvadu merged 6 commits intoAdysTech:masterfrom
tituszban:strongly-typed

Conversation

@tituszban
Copy link
Copy Markdown

  • Added methods to query and post data using strongly typed classes that have properties decorated with custom attributes.
  • Fixed repeated typo in InfluxDBClientTests.cs

@mvadu
Copy link
Copy Markdown
Contributor

mvadu commented Aug 19, 2020

Thank you @tituszban for your work. It looks extensive. I have to do some tests on my own before I can merge this. In the mean time can you update the readme example to show a use case where you are posting set of integer values for example?

Comment thread README.md
@tituszban
Copy link
Copy Markdown
Author

In the mean time can you update the readme example to show a use case where you are posting set of integer values for example?

Does my recent update help clarify this?

Copy link
Copy Markdown
Contributor

@mvadu mvadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the sake of keeping it consistent could you please update to InfluxDB from InfluxDb ? So far all the objects in this library been addressing DB, and if possible I would like to keep it that way. sorry for being nitpicky.

Comment thread src/Attributes/InfluxDbField.cs Outdated
Comment thread src/Attributes/InfluxDbMeasurementName.cs Outdated
Comment thread src/Attributes/InfluxDbPrecision.cs Outdated
Comment thread src/Attributes/InfluxDbTag.cs Outdated
Comment thread src/Attributes/InfluxDbTag.cs Outdated
Comment thread src/Attributes/InfluxDbTime.cs Outdated
@mvadu
Copy link
Copy Markdown
Contributor

mvadu commented Aug 24, 2020

In the mean time can you update the readme example to show a use case where you are posting set of integer values for example?

Does my recent update help clarify this?

Yes, that makes more sense..

@tituszban
Copy link
Copy Markdown
Author

Not nitpicky at all, naming conventions are important, sorry for missing it. Fixed.

Copy link
Copy Markdown
Contributor

@mvadu mvadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I noticed one small bug. Please fix that. Also can you update the minor version (Version AssemblyVersion and FileVersion tags in csproj file) so I can push as an update to Nuget?

Comment thread src/DataStructures/InfluxDBClient.cs Outdated
@tituszban
Copy link
Copy Markdown
Author

Also can you update the minor version (Version AssemblyVersion and FileVersion tags in csproj file) so I can push as an update to Nuget?

Updated to 0.21.0.0.

Add Thank You note for @tituszban
@mvadu mvadu merged commit 779b171 into AdysTech:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants