Conversation
This commit updates top-level dependency constraints in `pyproject.toml` to their latest compatible versions and regenerates all lock files (`uv.lock`, `requirements.lock`, and `requirements-dev.lock`). Key changes: - Updated `pysocks`, `aiosqlite`, `pymediainfo`, `pymongo`, `ElectroCrypto`, and `anyio` minimum versions in `pyproject.toml`. - Bumped `hatch` and `pytest` minimum versions in `dev` extra. - Updated `sphinx` constraint to `<10.0.0` and added minimum versions for other documentation and development tools. - Regenerated `uv.lock` with latest compatible versions. - Re-exported `requirements.lock` and `requirements-dev.lock` with hashes using `uv export`, ensuring consistency across dependency management tools. - Verified all tests pass in the updated environment. Co-authored-by: 5hojib <107526130+5hojib@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefreshes and pins all Python dependencies to current compatible versions, updating pyproject minimum versions and regenerating all lockfiles for runtime, dev, and uv-based environments. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @5hojib, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request comprehensively updates and locks all project dependencies, ensuring that the development and production environments utilize the most current and compatible package versions. The changes involve updating explicit minimum version requirements in Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Now that minimum versions are specified, consider adding upper bounds (especially for libraries known to introduce breaking changes in major releases like
pymongoandsphinx) to avoid unexpected breakage from future incompatible releases. - The change from
sphinx<9.0.0tosphinx<10.0.0potentially widens the allowed major-version range; verify that the project is actually compatible with Sphinx 9.x and, if not, keep the upper bound aligned with the last known compatible major version.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Now that minimum versions are specified, consider adding upper bounds (especially for libraries known to introduce breaking changes in major releases like `pymongo` and `sphinx`) to avoid unexpected breakage from future incompatible releases.
- The change from `sphinx<9.0.0` to `sphinx<10.0.0` potentially widens the allowed major-version range; verify that the project is actually compatible with Sphinx 9.x and, if not, keep the upper bound aligned with the last known compatible major version.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request updates dependency management from rye to uv, leading to a complete regeneration of requirements-dev.lock and requirements.lock files, which now include SHA256 hashes for all dependencies. The pyproject.toml file has been updated to specify minimum version requirements for core, development, and documentation dependencies, including an increased upper bound for sphinx. The uv.lock file reflects these changes by introducing more granular Python version resolution markers and updating specific package versions like docutils and sphinx to support different Python environments (e.g., Python 3.11 and 3.12+), while also removing the roman-numerals-py package.
Updated all dependencies to their latest compatible versions and locked them in
uv.lock,requirements.lock, andrequirements-dev.lock. Also updatedpyproject.tomlto reflect these updates as minimum version requirements.PR created automatically by Jules for task 14347183005228516033 started by @5hojib
Summary by Sourcery
Update dependency version constraints and lockfiles to current compatible releases.
Enhancements:
Build: