Skip to content

Add some constants#48

Merged
jorgepiloto merged 1 commit intoAeroPython:masterfrom
jorgepiloto:constants
Mar 15, 2020
Merged

Add some constants#48
jorgepiloto merged 1 commit intoAeroPython:masterfrom
jorgepiloto:constants

Conversation

@jorgepiloto
Copy link
Copy Markdown
Member

Partially solves for #46 by adding Earth's radius and gravity acceleration surface value. Makes use of the units module ✈️

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #48 into master will decrease coverage by 0.66%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   72.78%   72.12%   -0.67%     
==========================================
  Files          10       11       +1     
  Lines         327      330       +3     
==========================================
  Hits          238      238              
- Misses         89       92       +3
Impacted Files Coverage Δ
src/skaero/constants.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a703b4...1401f8f. Read the comment docs.

@jorgepiloto
Copy link
Copy Markdown
Member Author

Though decreasing the coverage, I will merge this since does not introduce huge complexity in the code. Furthermore, let me open an issue on coverage increase for the overall package.

@jorgepiloto jorgepiloto merged commit 3f8f765 into AeroPython:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants