Conversation
Add a new page to provide guidance on how AerynOS would like PR's submitted to it's repositories. Mainly focused on the recipes repo however I've tried to make it generic as well. Utilised current Solus and old Solus-Project documentation as guidance.
ermo
left a comment
ermo
left a comment
There was a problem hiding this comment.
Very good start.
I think we need to mention active, imperative voice and then find a recent example where we've actually followed the guidance herein. *ahem*
Summary: Add an aside to highlight AerynOS' requirement to use the immperative mood for git commits
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
|
Couple of comments after reading the entire thing: Perhaps not for this PR but the other one we want people to add into a recipe why a specific flag was added if it deviates from the expected macros. I'm not sure if the line length matters personally, Is that really something we wish to enforce? Perhaps if it's excessive but I think most proper tools would already wrap it at that point like it does here. |
Updating-an-existing-recipe page
Co-authored-by: Rune Morling <ermo@serpentos.com>
Co-authored-by: Rune Morling <ermo@serpentos.com>
Co-authored-by: Rune Morling <ermo@serpentos.com>
Co-authored-by: Rune Morling <ermo@serpentos.com>
|
I think all review points have been resolved so let me know if anything else stands out. |
ermo
left a comment
ermo
left a comment
There was a problem hiding this comment.
I think it's time to get this landed, as people using it will show if clarifications are needed.
4 participants
Summary
New page for guidance on how to submit a PR to AerynOS; mainly focused on recipes repo but also somewhat generic in guidance:
Test plan