API15 + Luna#103
Conversation
- polish bone editor and fix pop ups and bugs - update hooks to match cs - fix repo api version
|
Welp, that certainly means c+ might take some time to be available for 7.5 as I need to find a decent chunk of free time to review all that and this will likely need to be pushed to testing first before common availability. With that said I agree that moving to Luna is important and thank you for doing that because that's certainly not something I have the time to do. |
| Im.Separator(); | ||
|
|
||
| if (ImGui.Button("Owned Actors Temporary Profile Test")) | ||
| if (Im.Button("Owned Actors Temporary Profile Test")) |
There was a problem hiding this comment.
Literals passed to ImSharp should be UTF-8 to avoid conversions at runtime. Luna has a Roslyn analyzer/generator module that can generate compile-time warnings for that kind of stuff, see my next comment.
| <ProjectReference Include="..\CustomizePlus.GameData\CustomizePlus.GameData.csproj" /> | ||
| <ProjectReference Include="..\submodules\ECommonsLite\ECommonsLite\ECommonsLite.csproj" /> | ||
| <ProjectReference Include="..\submodules\OtterGui\OtterGui.csproj" /> | ||
| <ProjectReference Include="..\submodules\Luna\Luna\Luna.csproj" /> |
There was a problem hiding this comment.
If you want to use Luna's Roslyn analyzer/generator module to get compile-time warnings for inefficient use of Luna/ImSharp functions (and more bells and whistles), you can add it this way:
| <ProjectReference Include="..\submodules\Luna\Luna\Luna.csproj" /> | |
| <ProjectReference Include="..\submodules\Luna\Luna\Luna.csproj" /> | |
| <ProjectReference Include="..\submodules\Luna\Luna.Generators\Luna.Generators.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" /> |
| @@ -436,7 +434,7 @@ private void DrawUrlButton(string text, string url, uint buttonColor, float widt | |||
| _messageService.NotificationMessage($"Unable to open url {url}.", NotificationType.Error, false); | |||
| } | |||
There was a problem hiding this comment.
How relevant would be Dalamud.Utility.Util.OpenLink to that?
- rework state block to interact better with dalamud's font scaling, etc (doesn't overflow into the tabs anymore when window too small in width) - highlight bone editor cells and rows based on edit state - "improve" input sliders to match better with the highlighted cells now as well - bump submodules
3 participants
this is a pretty decent size of a change but it is needed for longevity of the plugin, as OtterGui is mostly being superseded by Luna.
since all the latest versions of the Penumbra submodules are requiring it now, it's the best time to move to it.
what do we gain:
changes:
most changes were tested locally but if there might be issues related to ui or anything else, i'll take care of them once found