Skip to content

Conversation

@rabenhorst
Copy link
Contributor

There is a bug in the parseCreateDatabase which results in nil pointer when setting the engine for a replicated database, because it sets StatementEnd to onCluster.End() after checking if engineExpr is nil.

if engineExpr != nil {
StatementEnd = onCluster.End()
}

In this PR this is fixed and test case for replicated database is added.

Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rabenhorst Good catch!

@git-hulk git-hulk merged commit 42fd0bb into AfterShip:master Nov 17, 2025
2 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19428897560

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 50.935%

Totals Coverage Status
Change from base Build 19351970609: 0.03%
Covered Lines: 7842
Relevant Lines: 15396

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants