Add support of parsing SETTING boolean values #213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking as https://clickhouse.com/docs/operations/settings/settings some SETTINGS are defined as Bool with the value either being a 1 or a 0.
The clickhouse codebase and examples look like it is valid to define these as the value true or false as well as 1 or 0.
This PR adds the ability to parse both.
I am not too sure to this solution as the output will be harder to parse by an end user given that they will need to take care to accommodate either a NumberLiteral or a BoolLiteral. Maybe both cases should return the same one e.g.
Happy to change as you think?