Skip to content

Conversation

@sharadgaur
Copy link
Contributor

Fix for this #216

Signed-off-by: Sharad Gaur <sharadgaur@gmail.com>
Signed-off-by: Sharad Gaur <sharadgaur@gmail.com>
Signed-off-by: Sharad Gaur <sharadgaur@gmail.com>
@coveralls
Copy link

coveralls commented Nov 20, 2025

Pull Request Test Coverage Report for Build 19557576815

Details

  • 46 of 77 (59.74%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 51.054%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/walk.go 3 7 42.86%
parser/ast_visitor.go 0 5 0.0%
parser/parser_table.go 36 42 85.71%
parser/ast.go 7 23 30.43%
Totals Coverage Status
Change from base Build 19522671202: 0.04%
Covered Lines: 7943
Relevant Lines: 15558

💛 - Coveralls

@git-hulk
Copy link
Member

@sharadgaur Thanks for your quick fix.

The PR looks good to me. Could you please add NamedParameterExpr to walk.go? So that we could visit this expression while walking through the AST.

Signed-off-by: Sharad Gaur <sharadgaur@gmail.com>
@sharadgaur
Copy link
Contributor Author

@sharadgaur Thanks for your quick fix.

The PR looks good to me. Could you please add NamedParameterExpr to walk.go? So that we could visit this expression while walking through the AST.

Done

@git-hulk
Copy link
Member

git-hulk commented Nov 21, 2025

@sharadgaur Thanks for your great work.

@git-hulk git-hulk merged commit 699e78f into AfterShip:master Nov 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants