Add line break and indentation for SETTINGS clause in beautify mode

[Copilot]

• Understand the issue: SETTINGS clause should appear on a new line with indentation
• Modify SettingsClause.FormatSQL() to add indentation after SETTINGS keyword
• Fix trailing spaces in formatted output
• Update test fixture expectations
• Run tests to verify the changes
• Code review completed - no critical issues
• Security scan completed - no vulnerabilities found
• Merge master branch and resolve conflicts
• Fix APPEND clause formatting in CREATE MATERIALIZED VIEW
• Fix SETTINGS formatting in ALTER TABLE statements

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Add an ident break for SETTINGS</issue_title>
<issue_description>The original beautiful format is:

SELECT
  number,
  x,
  y
FROM (SELECT
  number
FROM system.numbers
LIMIT 5) AS f
ANY LEFT JOIN
  (SELECT
    x,
    y
  FROM table_1) AS s ON f.number = s.x
SETTINGS additional_table_filters={'system.numbers': 'number != 3', 'table_1': 'x != 2'};

The expected beautiful format is:

SELECT
  number,
  x,
  y
FROM (SELECT
  number
FROM system.numbers
LIMIT 5) AS f
ANY LEFT JOIN
  (SELECT
    x,
    y
  FROM table_1) AS s ON f.number = s.x
SETTINGS
  additional_table_filters={'system.numbers': 'number != 3', 'table_1': 'x != 2'};
```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

• Fixes Add an ident break for SETTINGS #239

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[git-hulk]

@copilot Resolve conflicts using make update_test

[Copilot]

@copilot Resolve conflicts using make update_test

I ran make update_test and all tests pass successfully. The test fixtures are already up to date with the changes. No conflicts found.

[Copilot]

Pull request overview

This pull request modifies the SQL beautifier to format the SETTINGS clause on a new line with proper indentation, making it consistent with other multi-line clauses like SELECT items, ORDER BY, and WITH.

Changes:

• Modified SettingsClause.FormatSQL() to use the Indent()/Dedent() pattern with Break() calls between items
• Changed comma separator from ", " to , to eliminate trailing whitespace before line breaks
• Updated 14 test files to reflect the new SETTINGS formatting behavior

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
parser/format.go	Core formatting change to SettingsClause.FormatSQL() implementing multi-line formatting with proper indentation
parser/testdata/query/format/beautify/select_with_settings_additional_table_filters.sql	Updated expected output for SELECT statements with SETTINGS clause
parser/testdata/ddl/format/beautify/create_with_time_zone.sql	Updated expected output for CREATE TABLE with multiple settings
parser/testdata/ddl/format/beautify/create_table_with_tuple_fields.sql	Updated expected output for CREATE TABLE with single setting
parser/testdata/ddl/format/beautify/create_table_with_ttl_policy.sql	Updated expected output for CREATE TABLE with multiple settings and TTL
parser/testdata/ddl/format/beautify/create_table_with_sample_by.sql	Updated expected output for CREATE TABLE with SAMPLE BY and settings
parser/testdata/ddl/format/beautify/create_table_with_nullable.sql	Updated expected output for CREATE TABLE with nullable fields
parser/testdata/ddl/format/beautify/create_table_with_keyword_partition_by.sql	Updated expected output for CREATE TABLE with keyword partition
parser/testdata/ddl/format/beautify/create_table_with_index.sql	Updated expected output for CREATE TABLE with indexes and multiple settings
parser/testdata/ddl/format/beautify/create_table_with_enum_fields.sql	Updated expected output for CREATE TABLE with enum fields
parser/testdata/ddl/format/beautify/create_table_with_codec_delta.sql	Updated expected output for CREATE TABLE with codec settings
parser/testdata/ddl/format/beautify/create_materialized_view_with_refresh.sql	Updated expected output for CREATE MATERIALIZED VIEW with REFRESH and settings (contains formatting issue)
parser/testdata/ddl/format/beautify/create_distributed_table.sql	Updated expected output for CREATE DISTRIBUTED TABLE
parser/testdata/ddl/format/beautify/alter_table_drop_detach_partition.sql	Updated expected output for ALTER TABLE with settings
parser/testdata/ddl/format/beautify/alter_table_add_column.sql	Updated expected output for ALTER TABLE ADD COLUMN with settings

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[git-hulk]

@copilot Merge the master branch and resolve conflicts

[Copilot]

@copilot Merge the master branch and resolve conflicts

Merged master branch successfully. Conflicts in test fixtures were resolved using make update_test. The changes now include both FROM clause indentation (from master) and SETTINGS clause indentation (from this PR). All tests pass. Commit: 335a53b

[coveralls]

Pull Request Test Coverage Report for Build 21973856305

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 15 of 16 (93.75%) changed or added relevant lines in 1 file are covered.
• 67 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.03%) to 51.183%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
parser/format.go	15	16	93.75%

Files with Coverage Reduction	New Missed Lines	%
parser/format.go	67	87.11%

Totals
Change from base Build 21973451960:	0.03%
Covered Lines:	8089
Relevant Lines:	15804

---

💛 - Coveralls

[git-hulk]

@copilot

ALTER TABLE test.events_local ON CLUSTER 'default_cluster' ADD COLUMN f1 String AFTER f0 SETTINGS
  alter_sync=2;

Should be:

ALTER TABLE test.events_local ON CLUSTER 'default_cluster' ADD COLUMN f1 String AFTER f0
SETTINGS
  alter_sync=2;

[Copilot]

@copilot

ALTER TABLE test.events_local ON CLUSTER 'default_cluster' ADD COLUMN f1 String AFTER f0 SETTINGS

...

Fixed in commit 5910b22. Changed ALTER TABLE operations (ADD COLUMN, DETACH PARTITION, DROP PARTITION) to use Break() before SETTINGS, so it now appears on a new line as expected:

ALTER TABLE test.events_local ON CLUSTER 'default_cluster' ADD COLUMN f1 String AFTER f0
SETTINGS
  alter_sync=2;