fix: support expressions (dotted column refs) in DISTINCT ON#258
Merged
git-hulk merged 2 commits intoAfterShip:masterfrom Mar 17, 2026
Merged
fix: support expressions (dotted column refs) in DISTINCT ON#258git-hulk merged 2 commits intoAfterShip:masterfrom
DISTINCT ON#258git-hulk merged 2 commits intoAfterShip:masterfrom
Conversation
parseDistinctOn() was calling parseIdent() which only handles simple identifiers. Queries like DISTINCT ON (t.id, t.name) would fail because the dot was not recognized. Changed to parseExpr() so that any valid column expression (including table.column references) is accepted.
git-hulk
reviewed
Mar 16, 2026
Member
|
@disq Thanks for your fix. Left one comment. |
git-hulk
approved these changes
Mar 17, 2026
Member
|
@disq Thanks for your contribution. |
Contributor
Author
|
Thanks for the review and merge, just updated the PR body to match as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseDistinctOn()was callingparseIdent()which only handles simple identifiers. Queries likeDISTINCT ON (t.id, t.name)would fail because the dot was not recognized. Changed toParseNestedIdentifier()so thattable.columnreferences are accepted.