Ensure projections can have either an order by or a group by#266
Merged
git-hulk merged 1 commit intoAfterShip:masterfrom Apr 25, 2026
Merged
Ensure projections can have either an order by or a group by#266git-hulk merged 1 commit intoAfterShip:masterfrom
git-hulk merged 1 commit intoAfterShip:masterfrom
Conversation
git-hulk
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing PROJECTION parsing failed on PROJECTIONS with just a GROUP BY
This worked
But not
This PR makes both the GROUP BY and the ORDER BY optional.
It should also deal with when both are specified even if that will fail at runtime - I suppose that is the correct behaviour for a parser and formatter.