Skip to content

[Control Plane] Add tests for handlers/ui — dashboard + nodes #408

@santoshkumarradha

Description

@santoshkumarradha

Test coverage: Control plane UI handlers — dashboard.go + nodes.go

control-plane/internal/handlers/ui/ has a thin existing test suite (api_test.go, executions_test.go, config_test.go, packages_test.go, sse_test.go) but 1 500-LOC-class files like dashboard.go (1493 LOC, 29 funcs) and nodes.go are untested.

Scope

New test files:

  • control-plane/internal/handlers/ui/dashboard_test.go
  • control-plane/internal/handlers/ui/nodes_test.go

Suggested test cases

dashboard.goDashboardSummaryHandler, aggregateExecutions, formatNodeStats, dashboardCacheKey:

  • Empty store → zero counts for executions/nodes/workflows
  • Store with mixed execution statuses → counts grouped by normalized status
  • Store with stale nodes (heartbeat > N minutes old) → correct active/stale split
  • Cached response served on repeat request within TTL
  • Filter by window=24h → only recent executions counted
  • Error from storage → 500 with structured error body

nodes.goListNodesHandler, NodeDetailHandler, node-tag rendering:

  • Empty store → [] not null
  • Node with multiple versions → returns latest by default
  • ?include_versions=true → all versions returned
  • Tags rendered as displayed (approved vs proposed)
  • 404 on unknown node id
  • Filter by ?status=ready / ?phase=ready — only matching nodes

Fixture / mock boundary

Reuse handlers/ui/test_helpers_test.go setup. Narrow storage stub for the "not yet in existing helpers" cases. httptest.NewRecorder + gin.CreateTestContext.

Acceptance criteria

  • Both test files added
  • go test ./control-plane/internal/handlers/ui/... -run "Dashboard|Nodes" passes
  • Package coverage on handlers/ui up at least 10 pp

Size: L · Difficulty: intermediate · Language: Go


Part of epic #387parent tracker.


How to work on this

Setup

git clone https://github.com/Agent-Field/agentfield.git
cd agentfield
make install        # installs Go, Python (via uv), and Node deps
make build          # optional — builds the control plane binary

Run the baseline test suite

Before you change anything, run the tests for the language this issue targets so you know what "green" looks like:

  • Go control plane: cd control-plane && go test ./... -count=1
  • Go SDK: cd sdk/go && go test ./... -count=1
  • Python SDK: cd sdk/python && uv run pytest -q
  • TypeScript SDK: cd sdk/typescript && bun test

Package coverage baseline (so you can show improvement in the PR):

  • go test -cover ./control-plane/internal/...
  • uv run pytest --cov=agentfield sdk/python/tests
  • bun test --coverage (TypeScript)

Using Claude Code or another AI coding agent

This repo has a CLAUDE.md at the root that Claude Code and compatible agents will read automatically. A working flow:

  1. cd into the repo and run claude (or open in your IDE's agent).
  2. Paste this issue URL and say: "Please implement this issue, following every acceptance-criteria checkbox. Do not change source files — only add tests under the target path in the issue. When you're done, run the test suite command from the issue and paste the result."
  3. Let the agent read existing tests in the same package as a model for style / fixtures — we point to them in the issue.
  4. Run make lint before opening the PR.

See the AI-Assisted Contributions guide for testing requirements. Tag your PR with ai-assisted if you used an AI agent.

Claiming this issue

Comment I'd like to work on this and a maintainer will assign it to you. If you're new to open source, issues labelled good first issue or first-timers-only are hand-picked for a smooth first PR — we'll guide you if you get stuck.

Opening the PR

  • Branch name: tests/<short-description> or refactor/<short-description>
  • Link this issue in the PR description with Closes #<number>
  • Paste the before/after test output or coverage delta in the PR body
  • Keep the diff to the scope in this issue — no drive-by cleanups

Help & questions

  • Comment on this issue — we monitor all assigned issues.
  • Join the community Discord: run /gsd-join-discord or check the README for the invite.
  • For repo-wide questions, open a discussion with the help tag.

Metadata

Metadata

Assignees

No one assigned

    Labels

    ai-friendlyWell-documented task suitable for AI-assisted developmentarea:control-planeControl plane server functionalityarea:web-uiReact web UI functionalityhelp wantedExtra attention is neededtest-coveragePart of the drive to 95%+ test coveragetestsUnit test improvements and coverage

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions