[Refactor] Split control-plane/internal/services/vc_service.go (1783 LOC)

[santoshkumarradha]

Refactor: split control-plane/internal/services/vc_service.go (1783 LOC)

Part of the refactor god-files epic.

Evidence

$ wc -l control-plane/internal/services/vc_service.go
1783 control-plane/internal/services/vc_service.go

One file owns: VC issuance, resolution, validation, storage helpers, audit chain building, and serialization. These are distinct concerns with distinct reviewers.

Proposed split (same services package)

1. vc_issuance.go — IssueVC, signing, proof construction
2. vc_resolution.go — resolving a VC from its subject / issuer / id
3. vc_validation.go — signature verification, expiry, schema checks
4. vc_chain.go — building the audit chain (the GET /api/v1/did/workflow/{id}/vc-chain path)
5. vc_storage_helpers.go — thin wrappers over internal/storage for VC rows
6. vc_service.go — VCService struct + constructor + tiny public entry methods that fan out to the above

Rules for the PR

1. Pure moves. No renames. No logic changes.
2. Existing vc_service_test.go and vc_storage_test.go must pass unchanged.
3. One commit per extracted file.

Why this is safe

VCService methods are package-level from Go's perspective. File grouping is cosmetic.

Why this matters

VC code is security-critical. Splitting by concern lets reviewers focus on the part that changed instead of scanning the whole file.

Size: M · Difficulty: intermediate · Language: Go

---

Part of epic #388 — parent tracker.

---

How to work on this

Setup

git clone https://github.com/Agent-Field/agentfield.git
cd agentfield
make install        # installs Go, Python (via uv), and Node deps
make build          # optional — builds the control plane binary

Run the baseline test suite

Before you change anything, run the tests for the language this issue targets so you know what "green" looks like:

• Go control plane: cd control-plane && go test ./... -count=1
• Go SDK: cd sdk/go && go test ./... -count=1
• Python SDK: cd sdk/python && uv run pytest -q
• TypeScript SDK: cd sdk/typescript && bun test

Package coverage baseline (so you can show improvement in the PR):

• go test -cover ./control-plane/internal/...
• uv run pytest --cov=agentfield sdk/python/tests
• bun test --coverage (TypeScript)

Using Claude Code or another AI coding agent

This repo has a CLAUDE.md at the root that Claude Code and compatible agents will read automatically. A working flow:

1. cd into the repo and run claude (or open in your IDE's agent).
2. Paste this issue URL and say: "Please implement this issue, following every acceptance-criteria checkbox. Do not change source files — only add tests under the target path in the issue. When you're done, run the test suite command from the issue and paste the result."
3. Let the agent read existing tests in the same package as a model for style / fixtures — we point to them in the issue.
4. Run make lint before opening the PR.

See the AI-Assisted Contributions guide for testing requirements. Tag your PR with ai-assisted if you used an AI agent.

Claiming this issue

Comment I'd like to work on this and a maintainer will assign it to you. If you're new to open source, issues labelled good first issue or first-timers-only are hand-picked for a smooth first PR — we'll guide you if you get stuck.

Opening the PR

• Branch name: tests/<short-description> or refactor/<short-description>
• Link this issue in the PR description with Closes #<number>
• Paste the before/after test output or coverage delta in the PR body
• Keep the diff to the scope in this issue — no drive-by cleanups

Help & questions

• Comment on this issue — we monitor all assigned issues.
• Join the community Discord: run /gsd-join-discord or check the README for the invite.
• For repo-wide questions, open a discussion with the help tag.