fix(auth): allow root path to redirect to UI without auth #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When auth is enabled, accessing localhost:8080 directly would return
{"error":"unauthorized"} instead of redirecting to /ui/ where the
React app prompts for the API key.
The fix adds "/" to the auth middleware's skip list. This is safe
because the root path only performs a redirect to /ui/ - no data
is exposed.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
localhost:8080with auth enabled returns{"error":"unauthorized"}instead of redirecting to the UI login pageChanges Made
/to the auth middleware's skip list inauth.go/ui/, no sensitive data is exposedSecurity Note
This change is safe because:
/only redirects to/ui/(no data access)/ui/*was already in the skip list (serves static React files)/api/v1/*) still require authenticationTest Plan
AGENTFIELD_API_AUTH_API_KEY=secretlocalhost:8080→ should redirect to/ui/🤖 Generated with Claude Code