fix(ci): enable performance comments on fork PRs #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the Performance Check workflow into two parts to work around GitHub's security restriction that prevents fork PRs from posting comments. Changes: - memory-metrics.yml: Save benchmark results as artifact instead of posting comments directly - memory-metrics-report.yml: New workflow triggered by workflow_run that downloads results and posts the comment with base repo permissions This fixes the "Resource not accessible by integration" 403 error that occurred when external contributors opened PRs. Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
403 Resource not accessible by integrationerror that prevents the Performance Check workflow from posting comments on PRs from forks.Problem
GitHub restricts
GITHUB_TOKENpermissions on fork PRs for security. Thepull-requests: writepermission is ignored, causing the comment post to fail.Solution
Split into two workflows using the
workflow_runpattern:memory-metrics.yml) - Runs benchmarks and saves results as artifactmemory-metrics-report.yml) - Triggered byworkflow_run, downloads artifact and posts comment with base repo permissionsChanges
memory-metrics.yml: Replacedreportjob withsave-resultsjob that uploads benchmark data as artifactmemory-metrics-report.yml: New workflow that posts the performance commentTest Plan
🤖 Generated with Claude Code