fix: Claude Code provider captures response via subtype='success'#286
Merged
fix: Claude Code provider captures response via subtype='success'#286
Conversation
The Claude Code provider checked for type=='result' to extract the response text, but the Claude Agent SDK sends the final message with subtype=='success' (no type field). This caused HarnessResult.result to always be None. Fixes #252 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Performance
✓ No regressions detected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HarnessResult.resultalways beingNonewhen using the Claude Code providersubtype: "success"(nottype: "result"), so the provider never matched itFixes #252
Test plan
type: "result"format)test_execute_extracts_result_from_subtype_successverifies the real SDK formatclaude-agent-sdkinstalled🤖 Generated with Claude Code