fix: QA authorization issues — revoke idempotency, health checks, UI bugs#301
Merged
fix: QA authorization issues — revoke idempotency, health checks, UI bugs#301
Conversation
…bugs - Return 409 Conflict when revoking already-revoked agent tags instead of silently succeeding - Add health status and lifecycle checks to reasoner/skill execution handlers, returning 503 when agent node is unhealthy or offline - Handle zero-value timestamps in formatRelativeTime (display "—" instead of "Jan 1, 1") - Wire Refresh button on Authorization page to also re-fetch Agent Tags tab data Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Newly registered agents get HealthStatusUnknown (no heartbeat yet). The previous check required HealthStatusActive, which caused all functional tests to 503 because agents register and immediately invoke reasoners before a heartbeat can promote them to active. Changed the guard to only block HealthStatusInactive agents, which are definitively unreachable. Unknown and active agents pass through. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes four QA-reported issues on the control plane Authorization page and API:
409 Conflictwith{"error": "already_revoked"}instead of silently returning 200 successExecuteReasonerHandlerandExecuteSkillHandlernow verify agent health status before forwarding requests, returning503 Service Unavailablewhen the agent is unhealthy or offline (matching the pattern in the newerExecuteHandler)formatRelativeTime()now returns"—"for invalid or pre-1970 dates instead of displaying "Jan 1, 1" (Go'stime.Timezero value)Test plan
go build ./...)tsc --noEmit)HealthStatus/LifecycleStatuson test agents🤖 Generated with Claude Code