feat(python-sdk): add VideoOutput type and video support to MultimodalResponse (#469)#473
Merged
santoshkumarradha merged 2 commits intodev/add-videofrom Apr 18, 2026
Merged
Conversation
Contributor
Performance
✓ No regressions detected |
…imeouts (#469) - CRITICAL: sanitize filenames in save_all() via os.path.basename() to prevent path traversal from API-supplied filenames (videos + files) - HIGH: export VideoOutput from __init__.py alongside other Output types - HIGH: pass videos=[] in detect_multimodal_response() constructor call - HIGH: add timeout=120 to requests.get() in VideoOutput.save/get_bytes - MED: skip video mime_type files in the files save loop to avoid double-writes when videos appear in both _files and _videos
Contributor
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
Contributor
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VideoOutputPydantic model withsave(),get_bytes(), and metadata fields (duration,resolution,aspect_ratio,has_audio,cost_usd)videosproperty,has_videoproperty toMultimodalResponseis_multimodal,__repr__,save_allto include videosFalProvider.generate_video()to return bothfiles(backward compat) andvideosDX
Test plan
TestVideoOutputtests (create, metadata, base64, save, error)TestMultimodalResponseVideotests (has_video, is_multimodal, repr, backward compat)Closes #469