fix(web-ui): clear sidebar-close timeout on unmount#486
Merged
Conversation
handleCloseSidebar scheduled a 300ms setTimeout to clear the selected node after the close animation, but never tracked the handle. If the component unmounted within that window — common in tests — the timer still fired, called setState on an unmounted component, and React's internals threw "ReferenceError: window is not defined" after the test environment was torn down. Track the handle in a ref, clear on re-invocation, and clear on unmount. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
Contributor
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
Adds a test that opens, closes, reopens, and recloses the sidebar to exercise the clearTimeout branch on a pending handle, then waits long enough for the deferred setSelectedNode(null) callback to actually execute. Brings patch coverage on this PR's touched lines from 76% to 100%. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleCloseSidebarin WorkflowDAG/index.tsx:771 scheduled a 300mssetTimeout(() => setSelectedNode(null))to clear the selected node after the slide-out animation, but never tracked the handlesetStateon an unmounted component, and React's internals threwReferenceError: window is not definedafter the vitest env was torn downcoverage (web-ui)job; example failure on refactor(control-plane): split handlers/nodes.go into 5 focused files #481 here. Tests themselves all passed (583/583); the unhandled error is what failed the jobuseEffectcleanupTest plan
npm test -- --run src/test/components/WorkflowDAG/workflowDagSupplemental.test.tsxpasses with no unhandled errorsWorkflowDAG/test directory: pre-existing TZ-dependent failure inworkflowDagNodeWrapperLine.test.tsxreproduces on cleanmainand is unrelatedcoverage (web-ui)