fix(release): skip example requirements for prereleases #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore the check to skip updating example requirements for prerelease versions. Even though prereleases are now published to PyPI, pip install excludes them by default per PEP 440. Users running `pip install -r requirements.txt` would fail without the `--pre` flag. Examples should always pin to stable versions so they work out of the box. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the regression from PR #58 where example requirements were being updated to prerelease versions.
Even though prereleases are now published to PyPI (not TestPyPI),
pip installstill excludes them by default per PEP 440. Users runningpip install -r requirements.txtwould fail without the--preflag.Changes
bump_version.pyto skip example requirements>=0.1.19(last stable version)Root cause
In PR #58, I incorrectly removed the prerelease skip thinking that since we publish to regular PyPI, users could install prereleases. But pip's default behavior excludes prereleases regardless of which registry they're on.
Test plan
pip install -r requirements.txtworks in example directories🤖 Generated with Claude Code