feat(cli): add minimal trigger surface#605
Merged
Merged
Conversation
Contributor
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
Contributor
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
Member
Author
|
@AbirAbbas once this is merged, can we update readme of *-af examples with cli as primary call method and curl as secondry one for ease of friction free first experience? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #576
Summary
af call,af ls, andaf tailcommands for the minimal human trigger surface.Verification
go test ./cmd/af ./internal/cli ./internal/handlers ./internal/server -run 'Test(NewRoot|ResolveCall|ValidateInput|ExitCode|ListReasoners|StreamExecution|SetupRoutes|StartAdmin)'\n-go test ./cmd/af ./internal/cli ./internal/handlers\n-go build -tags "sqlite_fts5" -o /tmp/af-issue-576 ./cmd/af\n-python3 -m py_compile tests/functional/tests/test_af_trigger_cli.py\n-OPENROUTER_API_KEY=dummy PYTEST_ARGS='-q tests/test_af_trigger_cli.py' docker compose -f docker/docker-compose.local.yml -f <(printf 'services:\\n control-plane:\\n ports: !reset []\\n') up --build --abort-on-container-exit --exit-code-from test-runner\n\nNote: the functional Docker run used a transient compose override to remove the host8080:8080publish because port 8080 was already in use locally; service-to-service traffic still usedcontrol-plane:8080inside Docker.