chore(deps-dev): bump the npm_and_yarn group across 2 directories with 1 update#609
Conversation
Performance
⚠ Regression detected:
|
44b49c0 to
f240150
Compare
…h 1 update Bumps the npm_and_yarn group with 1 update in the /control-plane/web/client directory: [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Bumps the npm_and_yarn group with 1 update in the /sdk/typescript directory: [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `vitest` from 3.2.4 to 4.1.8 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.8/packages/vitest) Updates `vitest` from 3.2.4 to 4.1.8 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.8/packages/vitest) Updates `vitest` from 3.2.4 to 4.1.8 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.8/packages/vitest) Updates `vitest` from 3.2.4 to 4.1.8 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.8/packages/vitest) --- updated-dependencies: - dependency-name: vitest dependency-version: 4.1.8 dependency-type: direct:development - dependency-name: vitest dependency-version: 4.1.8 dependency-type: direct:development - dependency-name: vitest dependency-version: 4.1.8 dependency-type: direct:development - dependency-name: vitest dependency-version: 4.1.8 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
f240150 to
fc157fe
Compare
santoshkumarradha
left a comment
There was a problem hiding this comment.
Thanks for the update. This one is not merge-safe yet on the current repo baseline.
Two concrete blockers showed up in CI:
TypeScript SDK CI / build-and-test (18)fails becausevitest@4.1.8requires Node^20 || ^22 || >=24, while this repo still tests the TypeScript surfaces on Node 18.TypeScript SDK CI / build-and-test (20)also fails intests/ai_client_extra.test.tswithStatelessRateLimiter ... is not a constructor, so the bump changes test/runtime behavior beyond the engine requirement.
Given those failures, I would keep this blocked rather than merge a major Vitest jump into the current matrix. If we want Vitest 4 here, we should do it in a follow-up that first moves the affected CI jobs and package support to Node 20+, then fixes the rate-limiter mocking breakage in the SDK tests.
Stale after the Vitest 4 remediation commit was pushed to the PR branch.
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
|
I pushed two remediation commits for the Vitest 4 update:
Local verification I ran before pushing:
I’ll wait for the rerun and merge once CLA, required checks, review, and branch protections are satisfied. |
santoshkumarradha
left a comment
There was a problem hiding this comment.
I reviewed the Vitest 4 update after the remediation commits. The Node matrix now matches Vitest 4's engine support, the SDK mock breakage is fixed with a constructable test double, and the coverage contract reset is documented as a Vitest 4/V8 accounting change with clean patch coverage. Local tests and the coverage gate validation look good from my side; waiting on the rerun of required checks before merge.
Bumps the npm_and_yarn group with 1 update in the /control-plane/web/client directory: vitest.
Bumps the npm_and_yarn group with 1 update in the /sdk/typescript directory: vitest.
Updates
vitestfrom 3.2.4 to 4.1.8Release notes
Sourced from vitest's releases.
... (truncated)
Commits
e61f2ddchore: release v4.1.8e4067b3fix(browser): disable clientcdpAPI whenallowWrite/allowExec: false[ba...a09d472chore: release v4.1.7a8fd24cchore: release v4.1.618af98cfix(browser): simplify orchestrator otel carrier (#10285)3188260feat(browser): provide project reference inToMatchScreenshotResolvePath(#...e399846chore: release v4.1.57dc6d54Revert "fix: respect diff config options in soft assertions (#8696)"9787dedfix: respect diff config options in soft assertions (#8696)325463afix(ast-collect): recognize _vi_import prefix in static test discovery (#10...Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for vitest since your current version.
Updates
vitestfrom 3.2.4 to 4.1.8Release notes
Sourced from vitest's releases.
... (truncated)
Commits
e61f2ddchore: release v4.1.8e4067b3fix(browser): disable clientcdpAPI whenallowWrite/allowExec: false[ba...a09d472chore: release v4.1.7a8fd24cchore: release v4.1.618af98cfix(browser): simplify orchestrator otel carrier (#10285)3188260feat(browser): provide project reference inToMatchScreenshotResolvePath(#...e399846chore: release v4.1.57dc6d54Revert "fix: respect diff config options in soft assertions (#8696)"9787dedfix: respect diff config options in soft assertions (#8696)325463afix(ast-collect): recognize _vi_import prefix in static test discovery (#10...Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for vitest since your current version.
Updates
vitestfrom 3.2.4 to 4.1.8Release notes
Sourced from vitest's releases.
... (truncated)
Commits
e61f2ddchore: release v4.1.8e4067b3fix(browser): disable clientcdpAPI whenallowWrite/allowExec: false[ba...a09d472chore: release v4.1.7a8fd24cchore: release v4.1.618af98cfix(browser): simplify orchestrator otel carrier (#10285)3188260feat(browser): provide project reference inToMatchScreenshotResolvePath(#...e399846chore: release v4.1.57dc6d54Revert "fix: respect diff config options in soft assertions (#8696)"9787dedfix: respect diff config options in soft assertions (#8696)325463afix(ast-collect): recognize _vi_import prefix in static test discovery (#10...Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for vitest since your current version.
Updates
vitestfrom 3.2.4 to 4.1.8Release notes
Sourced from vitest's releases.
... (truncated)
Commits
e61f2ddchore: release v4.1.8e4067b3fix(browser): disable clientcdpAPI whenallowWrite/allowExec: false[ba...a09d472chore: release v4.1.7a8fd24cchore: release v4.1.618af98cfix(browser): simplify orchestrator otel carrier (#10285)3188260feat(browser): provide project reference inToMatchScreenshotResolvePath(#...e399846chore: release v4.1.57dc6d54Revert "fix: respect diff config options in soft assertions (#8696)"9787dedfix: respect diff config options in soft assertions (#8696)325463afix(ast-collect): recognize _vi_import prefix in static test discovery (#10...Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for vitest since your current version.