test(functional): fix Docker-backed SDK test infra#709
Merged
Conversation
459972d to
78c6fd3
Compare
Contributor
Performance
✓ No regressions detected |
Contributor
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
Contributor
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
78c6fd3 to
c6c685d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #713
Summary
Fixes the Docker-backed SDK functional test infrastructure and makes the new tests exercise real end-to-end behavior.
Infrastructure fixes
deployments/docker/Dockerfile.control-planecan copycontrol-plane/...paths./api/v1/healthin Docker healthchecks and wait scripts.AGENTFIELD_STORAGE_MODE=postgresandAGENTFIELD_POSTGRES_URL.host.docker.internalhost mapping so the containerized control plane can call agents running on the host during functional tests.SDK functional test fixes
Agent(..., agentfield_server=...).Agentinstance itself to uvicorn instead ofagent.app.0.0.0.0while probing localhost for readiness./api/v1/execute/test-go-execution.addand assertsum == 5.Verification
docker compose -f test-infra/docker-compose.yml config./test-infra/scripts/start-env.shcd sdk/python && /tmp/agentfield-py-functional-venv/bin/pytest --collect-only -m functional tests/functionalcd sdk/python && /tmp/agentfield-py-functional-venv/bin/pytest -m functional tests/functional/test_agent_registration.py -qcd sdk/go && go test ./agentcd sdk/go && go test -tags functional -run TestFunctionalExecution -count=1 -v .