feat(install): macOS Node install falls back to nvm without Homebrew#102
Merged
duguwanglong merged 1 commit intomainfrom Apr 13, 2026
Merged
feat(install): macOS Node install falls back to nvm without Homebrew#102duguwanglong merged 1 commit intomainfrom
duguwanglong merged 1 commit intomainfrom
Conversation
- Add FLOCKS_NVM_INSTALL_SCRIPT_URL and load_nvm() for nvm-based Node install - When brew is absent but curl exists, install/load nvm then nvm install/use MIN_NODE_MAJOR - Extend install script source tests; add bash harness test for nvm fallback path - Sync uv.lock flocks editable version Made-with: Cursor
duguwanglong
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Homebrew is not installed on macOS, the installer now falls back to nvm (via configurable
FLOCKS_NVM_INSTALL_SCRIPT_URL) to satisfy the minimum Node.js major version, instead of failing immediately.Changes
NVM_INSTALL_SCRIPT_URL/FLOCKS_NVM_INSTALL_SCRIPT_URLandload_nvm().install_nodejs_macos: try Homebrew first; ifbrewis missing, use curl + nvm install/useMIN_NODE_MAJOR.test_install_script_sources.pywith source assertions and a bash harness test for the nvm path.